[PATCH] D55459: [DAGCombiner][X86] Prevent visitSIGN_EXTEND from returning N when (sext (setcc)) already has the target desired type for the setcc

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 9 04:07:59 PST 2018


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8614
+      if (SVT == N0.getValueType())
+        return SDValue();
+
----------------
Does it matter that this early outs so later combines (matchVSelectOpSizesWithSetCC) can't run?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55459/new/

https://reviews.llvm.org/D55459





More information about the llvm-commits mailing list