[llvm] r348670 - [SelectionDAG] Remove ISD::ADDC/ADDE from some undef handling code in getNode. NFCI

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 16:27:35 PST 2018


Author: ctopper
Date: Fri Dec  7 16:27:34 2018
New Revision: 348670

URL: http://llvm.org/viewvc/llvm-project?rev=348670&view=rev
Log:
[SelectionDAG] Remove ISD::ADDC/ADDE from some undef handling code in getNode. NFCI

These nodes should have two results. A real VT and a Glue. But this code would have returned Undef which would only be a single result. But we're in the single result version of getNode so these opcodes should never be seen by this function anyway.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=348670&r1=348669&r2=348670&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Fri Dec  7 16:27:34 2018
@@ -4994,8 +4994,6 @@ SDValue SelectionDAG::getNode(unsigned O
         return getConstant(0, DL, VT);
       LLVM_FALLTHROUGH;
     case ISD::ADD:
-    case ISD::ADDC:
-    case ISD::ADDE:
     case ISD::SUB:
     case ISD::UDIV:
     case ISD::SDIV:




More information about the llvm-commits mailing list