[PATCH] D55368: [Sanitizer] capsicum api subset interception

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 14:05:45 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7739
+  }
+
+  return -1;
----------------
Oh, It should be:
```
if (rights)
  COMMON_INTERCEPTOR_READ_RANGE(ctx, rights, sizeof(*rights));

return REAL(cap_rights_limit)(fd, rights);
```
let real one to handle errors



================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7749
+    if (ret == 0)
+      COMMON_INTERCEPTOR_WRITE_RANGE(ctx, rights, sizeof(*rights));
+    return ret;
----------------
same here, call REAL always and sanitize args if needed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55368/new/

https://reviews.llvm.org/D55368





More information about the llvm-commits mailing list