[PATCH] D55443: [test] Capture stderr from 'tar --version' call as well

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 13:00:15 PST 2018


mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: test/lit.cfg.py:100
         config.available_features.add('gnutar')
-    tar_version.wait()
----------------
ruiu wrote:
> Maybe a silly question, but is this OK to remove this line?
Yes. [[ https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate | communicate() ]] waits on the process.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55443/new/

https://reviews.llvm.org/D55443





More information about the llvm-commits mailing list