[PATCH] D55450: [TextAPI][elfabi] Make TBE handlers functions that return Errors

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 12:11:31 PST 2018


amontanez created this revision.
amontanez added reviewers: jakehehrlich, phosek, mcgrathr, jhenderson.
Herald added subscribers: llvm-commits, hiraditya, arichardson, mgorny, emaste.
Herald added a reviewer: espindola.

Since TBEHandler doesn't maintain state or otherwise have any need to be a class right now, the read and write functions have been moved out and turned into standalone functions. Additionally, the TBE read function has been updated to return an Expected value for better error handling. Tests have been updated to reflect these changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D55450

Files:
  llvm/include/llvm/TextAPI/ELF/TBEHandler.h
  llvm/lib/TextAPI/ELF/TBEHandler.cpp
  llvm/unittests/TextAPI/CMakeLists.txt
  llvm/unittests/TextAPI/ELFYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55450.177272.patch
Type: text/x-patch
Size: 5955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181207/34dce258/attachment.bin>


More information about the llvm-commits mailing list