[PATCH] D55403: [PHIElimination] Allow breaking loop backedges in certain cases.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/CodeGen/PHIElimination.cpp:63
+                                            "allow splitting a loop "
+                                            "backedge (0=never)"));
 
----------------
I believe this should be target dependent. I.e., we should get that through a target API.
We can keep the option for testing though.


================
Comment at: lib/CodeGen/PHIElimination.cpp:643
+        }
+        ++NumBackedgeSplits;
+        if (NumBackedgeSplits < BackedgeSplitThreshold) {
----------------
Maybe a name that convey that this is the number of copies on the backend edges would be a better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55403/new/

https://reviews.llvm.org/D55403