[PATCH] D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 04:22:41 PST 2018


RKSimon added a comment.

Use getConstantOperandVal where possible



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1132
+  case ISD::SMULFIX: {
+    unsigned Scale = cast<ConstantSDNode>(Node->getOperand(2))->getZExtValue();
+    Action = TLI.getFixedPointOperationAction(Node->getOpcode(),
----------------
unsigned Scale = Node->getConstantOperandVal(2);


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:418
+  case ISD::SMULFIX: {
+    unsigned Scale = cast<ConstantSDNode>(Node->getOperand(2))->getZExtValue();
+    Action = TLI.getFixedPointOperationAction(Node->getOpcode(),
----------------
unsigned Scale = Node->getConstantOperandVal(2);


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5210
+
+  unsigned Scale = cast<ConstantSDNode>(Node->getOperand(2))->getZExtValue();
+  EVT VT = LHS.getValueType();
----------------
unsigned Scale = Node->getConstantOperandVal(2);


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54719/new/

https://reviews.llvm.org/D54719





More information about the llvm-commits mailing list