[PATCH] D55421: FastISel: take care to update iterators when removing instructions.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 03:00:08 PST 2018


t.p.northover created this revision.
Herald added subscribers: jsji, kbarton, hiraditya, javed.absar, nemanjai, mcrosier.

We keep a few iterators into the basic block we're selecting while performing FastISel. Usually this is fine, but occasionally code wants to remove already-emitted instructions. When this happens we have to be careful to update those iterators so they're not pointint at dangling memory.


Repository:
  rL LLVM

https://reviews.llvm.org/D55421

Files:
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/Target/AArch64/AArch64FastISel.cpp
  llvm/lib/Target/ARM/ARMFastISel.cpp
  llvm/lib/Target/PowerPC/PPCFastISel.cpp
  llvm/lib/Target/X86/X86FastISel.cpp
  llvm/test/CodeGen/AArch64/fast-isel-erase.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55421.177158.patch
Type: text/x-patch
Size: 4294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181207/c115c225/attachment.bin>


More information about the llvm-commits mailing list