[PATCH] D55350: [WebAssembly] clang-format/clang-tidy AsmParser (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 13:48:06 PST 2018


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:446
+      return expect(AsmToken::EndOfStatement, "EOL");
+
     } else if (DirectiveID.getString() == ".local") {
----------------
sbc100 wrote:
> Adding a newline here before a closing brace seems strange.
> 
Then in case code is structured like 
```
if (...) {
  ...
else if (...) {
  ...
} else if (...) {
  ...
}
...
```

And body of each `if` and `else if` is long enough so I'd like to add newlines, where should I add them?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55350/new/

https://reviews.llvm.org/D55350





More information about the llvm-commits mailing list