[PATCH] D53051: [llvm-tapi] initial commit, supports ELF text stubs

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

We are seeing a failure of YAMLWritesNoTBESyms on the WebAssembly waterfall due to this change:

  FAIL: LLVM-Unit :: TextAPI/./TapiTests/ElfYamlTextAPI.YAMLWritesNoTBESyms (3237 of 44396)
  ******************** TEST 'LLVM-Unit :: TextAPI/./TapiTests/ElfYamlTextAPI.YAMLWritesNoTBESyms' FAILED ********************
  Note: Google Test filter = ElfYamlTextAPI.YAMLWritesNoTBESyms
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from ElfYamlTextAPI
  [ RUN      ] ElfYamlTextAPI.YAMLWritesNoTBESyms
  /b/build/slave/linux/build/src/src/work/llvm/unittests/TextAPI/ELFYAMLTest.cpp:42: Failure
        Expected: Line1.str().data()
        Which is: "NeededLibs:      "
  To be equal to: Line2.str().data()
        Which is: "NeededLibs:      [ libc.so, libfoo.so, libbar.so ]"
  /b/build/slave/linux/build/src/src/work/llvm/unittests/TextAPI/ELFYAMLTest.cpp:42: Failure
        Expected: Line1.str().data()
        Which is: "  - libc.so"
  To be equal to: Line2.str().data()
        Which is: "Symbols:         {}"
  /b/build/slave/linux/build/src/src/work/llvm/unittests/TextAPI/ELFYAMLTest.cpp:42: Failure
        Expected: Line1.str().data()
        Which is: "  - libfoo.so"
  To be equal to: Line2.str().data()
        Which is: "..."

We suspect that its due to fact that LLVM_BUILD_LLVM_DYLIB and LLVM_LINK_LLVM_DYLIB are set on this builder.

Its seems that with the dylib use case the SequenceElementTraits from include/llvm/Support/YAMLTraits.h are in effect and we get:

  NeededLibs:      
    - libc.so
    - libfoo.so
    - libbar.so

Where as most builds get (and the test expects):

`NeededLibs:      [ libc.so, libfoo.so, libbar.so ]`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53051/new/

https://reviews.llvm.org/D53051