[PATCH] D55353: [WebAssembly] Add '.eventtype' directive support

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel accepted this revision.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:463
+      TOut.emitEventType(WasmSym);
+      // TODO: backend also calls TOut.emitIndIdx, but that is not implemented.
+      return expect(AsmToken::EndOfStatement, "EOL");
----------------
aheejin wrote:
> I don't really know what this TODO means, but because other directives have it, I just pasted it again here.
This comment is related to the comment above about WebAssemblyAsmPrinter::EmitFunctionBodyStart. Effectively it means that compared to that code, we're missing this particular emit, but it doesn't seem to matter


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55353/new/

https://reviews.llvm.org/D55353