[PATCH] D55347: [WebAssembly] TargetStreamer cleanup (NFC)

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 08:35:49 PST 2018


sbc100 added a comment.

There is a presensent for the "emit" functions in the streamer modifying symbols. For example:

  void MCELFStreamer::emitELFSize(MCSymbol *Symbol, const MCExpr *Value) {         
    cast<MCSymbolELF>(Symbol)->setSize(Value);                                     
  }   

I'm not saying this is the best, but it seems to have be designed or used this way in other targets, so I'd be tempted to use caution when refactoring.   I myself don't have enough to background to know if this is a direction we want to move in.  @sunfish  and @aardappel  might have a better idea.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55347/new/

https://reviews.llvm.org/D55347





More information about the llvm-commits mailing list