[PATCH] D55345: [AArch64] Refactor the scheduling predicates (NFC)

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

Hi Evandro,

Thanks for the patch.

Could you please update the diff?
I tried to apply your patch, but there were failures.
`AArch64InstrInfo::isExynosShiftFast()` is referenced by your patch, but it doesn't appear to exist upstream. In another case, the conflict was caused by a diff which appears to have been committed already.

Thanks,
Andrea



================
Comment at: llvm/lib/Target/AArch64/AArch64.td:130-133
 def FeatureExynosCheapAsMoveHandling : SubtargetFeature<"exynos-cheap-as-move",
     "ExynosAsCheapAsMove", "true",
-    "Use Exynos specific code in TargetInstrInfo::isAsCheapAsAMove()",
+    "Use Exynos specific handling of cheap instructions",
     [FeatureCustomCheapAsMoveHandling]>;
----------------
This change was already committed at r348398.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:708
   if (Subtarget.hasExynosCheapAsMoveHandling()) {
-    if (isExynosResetFast(MI) ||
-        isExynosShiftFast(MI) || isExynosShiftExtFast(MI))
+    if (isExynosCheapAsMove(MI))
       return true;
----------------
There is no `isExynosShiftFast()`.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.h:253-255
-  /// Returns true if the instruction is a constant shift left that can be
-  /// executed more quickly.
-  static bool isExynosShiftFast(const MachineInstr &MI, unsigned Extra = 0);
----------------
Not sure where `isExynosShiftFast` declaration comes from. It is not available at HEAD revision. So, this patch fails to apply.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55345/new/

https://reviews.llvm.org/D55345