[PATCH] D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -stdfor --cflags, --cxxflags & --ldflags

[Infinity Zero via Phabricator via llvm-commits]

infinity0 added a comment.

In D55174#1318718 <https://reviews.llvm.org/D55174#1318718>, @tstellar wrote:

> Don't we need to leave -fno-rtti here if LLVM was complied without rtti?  Also, rather than filtering out, would it be possible to explicitly add the flags that users need to successfully link/build against this install of LLVM?


Some projects are filtering out, some projects are filtering in - there is no standard approach currently.

This PR is suggesting indeed to filter-in, which I think is probably better. However neither me nor sylvestre knows both GCC and Clang well enough, to know if -I -D -std covers everything. If you know that -fno-rtti is necessary then yes of course it will have to be part of this PR as well.

Is this sort of logic already covered by pkg-config? It sounds like their developers would know the most about this topic. If so, perhaps in the long-run LLVM should move to that, rather than implementing its own?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55174/new/

https://reviews.llvm.org/D55174