[PATCH] D54713: [SCEV] Guard movement of insertion point for loop-invariants

Warren Ristow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 16:29:39 PST 2018


wristow added a comment.

This fix (rL347934 <https://reviews.llvm.org/rL347934>) was reverted at rL348426 <https://reviews.llvm.org/rL348426> because it was causing SEGVs in instcombine.  As noted in D55232 <https://reviews.llvm.org/D55232>, a similar fix as this one was originally committed about a year ago (rL289412 <https://reviews.llvm.org/rL289412>), but it was reverted shortly thereafter at rL289453 <https://reviews.llvm.org/rL289453>, because of OOB PHI operand access in instcombine.  The cause of the SEGVs here //may //be the same underlying issue.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54713/new/

https://reviews.llvm.org/D54713





More information about the llvm-commits mailing list