[PATCH] D51183: [clang-query] Continue if compilation command not found for some files

[Ilya Biryukov via Phabricator via llvm-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:127
 
+  if (SomeASTFailed)
+    return 1;
----------------
george.karpenkov wrote:
> ilya-biryukov wrote:
> > NIT: Maybe make only a single int with a more descriptive name, e.g. `ASTStatus`.
> > The return at the end would be `return ASTStatus != 0`. But up to you.
> Then why `return ASTStatus != 0` and not just `return ASTStatus` ?  :P
`return ASTStatus` is clearly better!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51183/new/

https://reviews.llvm.org/D51183