[PATCH] D55306: [RISCV, WIP] Lower TLS addresses using localexec

[Lewis Revill via Phabricator via llvm-commits]

lewis-revill marked an inline comment as done.
lewis-revill added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:475
+  // pointer, with the appropriate adjustment for the thread pointer offset.
+  // This generates the pattern (add (add_tprel (lui %tprel_hi(sym)) tp)
+  // %tprel_lo(sym))
----------------
jrtc27 wrote:
> Pattern should be `(add (add_tprel (lui %tprel_hi(sym)) tp %tprel_add(sym)) %tprel_lo(sym))` - you missed the `%tprel_add` operand to `add_tprel`.
I'll address this when I merge into D55305, thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55306/new/

https://reviews.llvm.org/D55306