[PATCH] D54394: [WIP][NewPM] Port msan

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 06:12:36 PST 2018


fedor.sergeev added a comment.

> - Make a free function for creating the global constructor function
> - The opt tool calls this function when passing a command line option

What is the benefit of having free function compared to having  a module-level pass that does the same?

> Consequently I need to keep state in the Pass, which is unfortunate.

This is really unfortunate. What about introducing (a module level) analysis?
It will have to be force-run on module level, but then we will be able to rely on AnalysisManager in terms of per-Module-per-Pipeline memory management.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54394/new/

https://reviews.llvm.org/D54394





More information about the llvm-commits mailing list