[PATCH] D55273: [test] Skip ThinLTO cache tests requiring atime setting on NetBSD

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 02:25:04 PST 2018


jhenderson accepted this revision.
jhenderson added a comment.

LGTM. Thinking about it a bit more, and I don't think using the cache will cause any actual problems if everything has the same access time, beyond potentially doing unnecessary work.



================
Comment at: test/ThinLTO/X86/cache.ll:1
 ; Verify first that *without* hash, we don't use the cache.
+; NetBSD: noatime mounts currently inhibit 'touch -a' updates
----------------
Please move this comment down to the first set of RUN commands, since that's what it's describing. The UNSUPPORTED directive and associated comment are best kept at the top of the file before anything else.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55273/new/

https://reviews.llvm.org/D55273





More information about the llvm-commits mailing list