[PATCH] D55290: [docs] Update llvm.loop metadata documentation.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 12:34:34 PST 2018


hfinkel added inline comments.


================
Comment at: docs/LangRef.rst:5100
+reference to itself. It was used to avoid collapsing of multiple loop
+metadata nodes into one. The use of 'distinct' metadata nodes is also
+obsolete.
----------------
Really? Why is it obsolete? (in any case, if that's true, it should be mentioned elsewhere in the LangRef).


================
Comment at: docs/LangRef.rst:5103
+
+Loop metadata nodes cannot be used as identifiers. It is
+neither persistent for the same loop through pass transformations nor
----------------
It is -> They are


================
Comment at: docs/LangRef.rst:5103
+
+Loop metadata nodes cannot be used as identifiers. It is
+neither persistent for the same loop through pass transformations nor
----------------
hfinkel wrote:
> It is -> They are
identifiers -> unique loop identifiers


================
Comment at: docs/LangRef.rst:5104
+Loop metadata nodes cannot be used as identifiers. It is
+neither persistent for the same loop through pass transformations nor
+unique to just one loop.
----------------
nor -> nor necessarily


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55290/new/

https://reviews.llvm.org/D55290





More information about the llvm-commits mailing list