[PATCH] D55228: [PDB] Emit S_UDT records in LLD

[Zachary Turner via Phabricator via llvm-commits]

zturner marked 2 inline comments as done.
zturner added inline comments.


================
Comment at: lld/test/COFF/s_udt.s:20
+# CHECK:      {{.*}} | S_UDT [size = 24] `StructTypedef`
+# CHECK:               original type = 0x1003
+# CHECK:      {{.*}} | S_UDT [size = 16] `Struct`
----------------
aganea wrote:
> Just to be sure, 0x1003 is here because of the yet unlanded D55236? It should read 0x1006 once it lands? You would need to re-generate this test at that point?
Yes, whoever lands second would need to update their patch.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp:64
 
   template <typename T> void addSymbol(const T &Symbol, MSFBuilder &Msf) {
     T Copy(Symbol);
----------------
aganea wrote:
> Since you removed `GSIStreamBuilder::addGlobalSymbol` below, do we still need this function?
I only removed the overload that takes a `UDTSym` (it was never called), but there are still other overloads.  Once we extend the hash lookup to include types other than `S_UDT`, we can evaluate the other methods.  I could also probably just change the `push_back` to an `addSymbol` since there's no reason not to.  I'll do that offline before I submit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55228/new/

https://reviews.llvm.org/D55228