[PATCH] D55233: Add objc_retain and objc_release intrinsics and codegen them to their runtime methods

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 11:31:58 PST 2018


erik.pilkington added a comment.

In D55233#1319010 <https://reviews.llvm.org/D55233#1319010>, @pete wrote:

> In D55233#1318897 <https://reviews.llvm.org/D55233#1318897>, @ahatanak wrote:
>
> > LGTM
>
>
> Thanks!
>
> Erik, did you have anything else required before landing this?


Patch LGTM, but are you planning on adding these to the LangRef? Its probably good enough to just list them and refer to https://clang.llvm.org/docs/AutomaticReferenceCounting.html#runtime-support for their semantics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55233/new/

https://reviews.llvm.org/D55233





More information about the llvm-commits mailing list