[PATCH] D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 11:02:26 PST 2018


ruiu added inline comments.


================
Comment at: lld/trunk/ELF/Arch/PPC64.cpp:744
+  llvm_unreachable("unsupported relocation type used in branch");
+  return false;
 }
----------------
Please do not write any code after `llvm_unreachable` as the code is literally unreachable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54868/new/

https://reviews.llvm.org/D54868





More information about the llvm-commits mailing list