[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

I'm in favor of using labels for the reasons you mentioned. It's also consistent with what we do elsewhere.



================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1559
+  EndLabel = Asm->createTempSymbol(Prefix + "end");
+  Asm->EmitLabelDifference(EndLabel, BeginLabel, 4);
+  Asm->OutStreamer->EmitLabel(BeginLabel);
----------------
Sometimes `sizeof(uint32_t)` is used here, but up to you. 



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281