[PATCH] D55236: [codeview] Look through typedefs in getCompleteTypeIndex

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 07:36:06 PST 2018


aganea added a comment.

> Fixes PR39853.

The issue I was discussing with Zachary occurs when using cl-generated OBJs with LLD (we haven't deployed clang in production yet).
Shouldn't there be something in LLD to completly fix PR39853?  Microsoft seems to be doing a post-merge pass to resolve forward-declared UDTs, see here <https://github.com/Microsoft/microsoft-pdb/blob/082c5290e5aff028ae84e43affa8be717aa7af73/PDB/dbi/mod.cpp#L2286> and here <https://github.com/Microsoft/microsoft-pdb/blob/082c5290e5aff028ae84e43affa8be717aa7af73/PDB/dbi/mod.cpp#L2795>.



================
Comment at: llvm/test/DebugInfo/COFF/udts-complete.ll:13
+; typedef Bar Baz;
+; static_assert(sizeof(Foo) == 8, "");
+; Baz gv;
----------------
`== 4`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55236/new/

https://reviews.llvm.org/D55236





More information about the llvm-commits mailing list