[PATCH] D54720: [PPC64] toc-indirect to toc-relative relaxation.

Tue Dec 4 07:17:48 PST 2018

sfertile marked 11 inline comments as done.
sfertile added inline comments.

================
Comment at: ELF/InputSection.cpp:900
+// pair in the case that relaxation is valid.
+static llvm::Optional<PPC64RelaxTo> relaxToPPC64(Relocation Rel) {
+  // If the symbol the relocation refers to is not the .toc section
----------------
grimar wrote:
> Seems the intention was to name it 'relaxTocPPC64'?
I named it relaxToPPC64 because the function is looking up the symbol we will potentially relax to. I failed to realize that its unfortunately close to relaxToc which would also make sense as a name :)

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54720/new/

https://reviews.llvm.org/D54720