[PATCH] D54698: [SelectionDAG] Initial support for FSHL/FSHR funnel shift opcodes (PR39467)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon marked 4 inline comments as done.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:1168
+
+  // Otherwise go ahead and unroll.
+  return DAG.UnrollVectorOp(Op.getNode());
----------------
spatel wrote:
> I realize this comment is copied, but it wasn't really adding value the first 3 times we said it either. :)
I agree its superfluous - I've removed this from all the VectorLegalizer cases in the patch. Naturally I'd commit is as NFC pre-commit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54698/new/

https://reviews.llvm.org/D54698