[PATCH] D55173: [llvm-mc] - Do not crash when referencing undefined debug sections.

[George Rimar via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL348243: [llvm-mc] - Do not crash when referencing undefined debug sections. (authored by grimar, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D55173?vs=176278&id=176569#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55173/new/

https://reviews.llvm.org/D55173

Files:
  llvm/trunk/lib/MC/ELFObjectWriter.cpp
  llvm/trunk/test/MC/ELF/undefined-debug.s


Index: llvm/trunk/test/MC/ELF/undefined-debug.s
===================================================================
--- llvm/trunk/test/MC/ELF/undefined-debug.s
+++ llvm/trunk/test/MC/ELF/undefined-debug.s
@@ -0,0 +1,5 @@
+// RUN: not llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o %t 2>&1 | FileCheck %s
+// CHECK: error: Undefined section reference: .debug_pubnames
+
+.section .foo,"", at progbits
+  .long  .debug_pubnames
Index: llvm/trunk/lib/MC/ELFObjectWriter.cpp
===================================================================
--- llvm/trunk/lib/MC/ELFObjectWriter.cpp
+++ llvm/trunk/lib/MC/ELFObjectWriter.cpp
@@ -669,6 +669,20 @@
     } else {
       const MCSectionELF &Section =
           static_cast<const MCSectionELF &>(Symbol.getSection());
+
+      // We may end up with a situation when section symbol is technically
+      // defined, but should not be. That happens because we explicitly
+      // pre-create few .debug_* sections to have accessors.
+      // And if these sections were not really defined in the code, but were
+      // referenced, we simply error out.
+      if (!Section.isRegistered()) {
+        assert(static_cast<const MCSymbolELF &>(Symbol).getType() ==
+               ELF::STT_SECTION);
+        Ctx.reportError(SMLoc(),
+                        "Undefined section reference: " + Symbol.getName());
+        continue;
+      }
+
       if (Mode == NonDwoOnly && isDwoSection(Section))
         continue;
       MSD.SectionIndex = SectionIndexMap.lookup(&Section);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55173.176569.patch
Type: text/x-patch
Size: 1523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181204/611ee20d/attachment.bin>