[PATCH] D54740: [NewPM] fixing asserts on deleted loop in -print-after-all

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

One place that I'm not seeing an update reflected (but I may just misunderstand)....



================
Comment at: lib/Passes/StandardInstrumentations.cpp:58
     const LazyCallGraph::SCC *C = any_cast<const LazyCallGraph::SCC *>(IR);
-    assert(C);
+    // We get nullptr here when current SCC gets invalidated by the pass.
+    if (C == nullptr)
----------------
fedor.sergeev wrote:
> philip.pfaffe wrote:
> > Is that still the case? You don't hook up the Invalidated callback below.
> Hmm... indeed. I did it in the followup which handles -print-module-scope part and it has not been posted yet  :-(
> Okey, let me clean this up once more.
Did this happen?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54740/new/

https://reviews.llvm.org/D54740