[PATCH] D55248: [ELF] Simplify getSectionPiece

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 01:54:15 PST 2018


grimar added a comment.

I think this kills the additional optimization we have here. Unfortunately, I do not remember
how much improvement this piece had in comparison with the simple code as your patch has,
but this was the code initially implemented by Rafael in r284594, which comment says:

  Add a faster binary search.
  
  Even with the hash table cache, binary search was still pretty
  hot. This can be made even faster with prefetching.
  
  Idea from http://cglab.ca/~morin/misc/arraylayout-v2/
  
  I will suggest moving this to llvm.

I do not know if that was moved to llvm (or if that what we might want atm, if not).


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55248/new/

https://reviews.llvm.org/D55248





More information about the llvm-commits mailing list