[PATCH] D55242: [llvm-rc] Support not expressions.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

LGTM. I presume that you've tested the testcase against rc.exe and that the output is bitexact with it?

I'll leave out the accept stamp for now to hopefully trigger @amccarth or someone else to give it another set of eyes during the next round of US daytime, else I'll stamp and commit it tomorrow.



================
Comment at: tools/llvm-rc/ResourceScriptParser.cpp:124
 //
+// 'not' expression is mostly useful got style values. It evaluates to 0,
+// but value given to the operator is stored separately from integer value.
----------------
"is mostly useful **for** style values"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55242/new/

https://reviews.llvm.org/D55242