[PATCH] D55247: [WebAssembly] Make WasmSymbol's signature usable for events

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 21:18:55 PST 2018


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Should the first word of the description be `WasmSymbol`



================
Comment at: include/llvm/BinaryFormat/Wasm.h:335
 inline bool operator==(const WasmEventType &LHS, const WasmEventType &RHS) {
-  return LHS.Attribute == RHS.Attribute && LHS.SigIndex == RHS.SigIndex;
 }
----------------
Did you mean to remove this?

EventTypes are not equal unless the signature is equal too right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55247/new/

https://reviews.llvm.org/D55247





More information about the llvm-commits mailing list