[PATCH] D55156: [asan] Split -asan-use-private-alias to -asan-use-odr-indicator

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka marked an inline comment as not done.
vitalybuka added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/Linux/odr-violation.cc:29
 // RUN: %clangxx_asan -mllvm -asan-use-private-alias %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE
+// RUN: %env_asan_opts=fast_unwind_on_malloc=0                          %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
+// RUN: %env_asan_opts=fast_unwind_on_malloc=0:use_odr_indicator=false  %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
----------------
Here is a problem. If we just enable -asan-use-private-alias we miss reports which we had on line 10.
So I am not sure if there is any value in using aliases without indicators. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55156/new/

https://reviews.llvm.org/D55156