[PATCH] D55235: llvm-objcopy: Improve/simplify llvm::Error handling during notes iteration

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

To comment further - the example in the docs which involves llvm::object::Archive's "range children(Error)" accessor isn't robust against this sort of problem either - if any caller returns early from within a loop over the children, I think they'll hit an assert too. (yeah, just tested that - and it fails as predicted)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55235/new/

https://reviews.llvm.org/D55235