[PATCH] D55239: [codeview] Emit typedefs of types derived from incomplete types

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 18:26:43 PST 2018


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1447
+  // Don't emit a UDT if we only have a forward declaration.
+  if (T && T->isForwardDecl())
+    return false;
----------------
zturner wrote:
> Is this sufficient?  If `T->isForwardDecl()` is true, does that mean the debug info does not contain a full decl at all?
Yes, the metadata has only a forward decl or a complete definition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55239/new/

https://reviews.llvm.org/D55239





More information about the llvm-commits mailing list