[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType

Mon Dec 3 15:02:45 PST 2018

sbc100 added a comment.

In D54873#1317523 <https://reviews.llvm.org/D54873#1317523>, @aheejin wrote:

> Yes in that case it's represented like sigindex of functions.
>
>   - Type:            FUNCTION                                                    
>     FunctionTypes:   [ 0, 0 ]                                                    
>   - Type:            EVENT                                                       
>     EventTypes:      [ 1 ]                   // here                                        
>     Events:                                                 
>       - Index:           0                                                       
>         Attribute:       0   
>   

So I guess my point is that its cleaner to keep the signature as part of the type so it can be specified the same in imports as in non-imports.  
And the original reason for this CL, which was to make the signature mutable for inputs to lld is no longer an issues, so I don't see any advantage to landing this CL now.  But I could still be missing something?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54873/new/

https://reviews.llvm.org/D54873