[PATCH] D55149: [WebAssembly] Enforce assembler emits to streamer in order.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked 2 inline comments as done.
aardappel added inline comments.


================
Comment at: test/MC/WebAssembly/assembler-binary.ll:1
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | FileCheck -check-prefix=ASM %s
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | llvm-mc -triple=wasm32-unknown-unknown -filetype=asm -o - | FileCheck -check-prefix=ASM %s
----------------
sbc100 wrote:
> Hmm, rather than running llc twice here you could do
> 
> ```
> ; RUN: llc -filetype=asm -asm-verbose=false %s -o %t.s
> ; RUN: FileCheck -check-prefix=ASM --input-file %t.s
> ; RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=asm %t.s -o - | FileCheck -check-prefix=ASM %s
> ```
> 
> Basically write the .s to a temp file and use that rather then generating and piping it twice.
> 
> I'm really not sure which is better but I thought I'd mention it as an option :)
Good idea! Removes 3 runs of llc. Though rather than `--input-file %t.s` it needs `-input-file %t.s %s`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55149/new/

https://reviews.llvm.org/D55149