[PATCH] D55228: [PDB] Emit S_UDT records in LLD

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: lld/test/COFF/s_udt.test:35
+
+; ModuleID = 'foo.cpp'
+source_filename = "foo.cpp"
----------------
Could you possibly add here the source code that generated this test?


================
Comment at: llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp:48
     T Copy(Symbol);
     Records.push_back(SymbolSerializer::writeOneSymbol(Copy, Msf.getAllocator(),
                                                        CodeViewContainer::Pdb));
----------------
Could someone insert twice the same S_UDT record by calling `GSIStreamBuilder::addGlobalSymbol(const UDTSym &Sym)`? Replace `Records.push_back` by a call to `addSymbol` in that case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55228/new/

https://reviews.llvm.org/D55228