[PATCH] D54769: [FileCheck] New option -warn

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 11:38:32 PST 2018


probinson added a comment.

In D54769#1317118 <https://reviews.llvm.org/D54769#1317118>, @dblaikie wrote:

> In D54769#1317107 <https://reviews.llvm.org/D54769#1317107>, @jdenny wrote:
>
> > I'm not sure which tests would be "simple", but any test that generates the FileCheck check file dynamically would certainly not work with such a script.
>
>
> I don't think there are any of those - at least I rather hope not.


I think some of FileCheck's own tests do this, but FileCheck tests are quite a unique case already.  Outside of that, I agree, dynamically generated check-files ought to be rare to non-existent.
There are plenty of tests that were generated by one script or another, but the tests themselves don't dynamically generate check files.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769





More information about the llvm-commits mailing list