[PATCH] D55060: [ThinLTO] Look through aliases in cache key calculations

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

Thanks for the feedback!



================
Comment at: lib/LTO/LTO.cpp:230
     for (auto &ImpF : ImpM.second)
       AddUsedThings(Index.findSummaryInModule(ImpF, ImpM.first()));
 
----------------
tejohnson wrote:
> Presumably this is where we were missing the base object, because we may have the alias in the import list but not its base object (but we will actually import the alias as a copy of the base object). My suggestion would be to check if the summary is an alias here, and if so call AddUsedThings a second time on the base object summary.
SGTM.

The `_or_null` in my new patch was out of caution rather than actual test failures. Please let me know if I should be able to assume `S != nullptr`, and I'm happy to drop that. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55060/new/

https://reviews.llvm.org/D55060