[PATCH] D55113: [llvm-dwarfdump] - Stop printing the bogus empty section name on invalid dwarf.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/trunk/test/tools/llvm-dwarfdump/X86/no_debug_addr.s:4-11
+## When .debug_addr is absent for some reason,
+## check we do not print a bogus section name.
+
+# CHECK:       DW_AT_ranges [DW_FORM_rnglistx]   (indexed (0x0) rangelist = 0x00000004
+# CHECK-NEXT:    [0x0000000000000000, 0x0000000000000001)
+# CHECK-NEXT:    [0x0000000000000000, 0x0000000000000002)
+# CHECK-NEXT:    [0x0000000000000003, 0x0000000000000004))
----------------
Could you provide the source (& compilation commands) for this assembly in a comment here so it's easier to eyeball what the input is to this test rather than reading all the assembly?

Also, does this need 3 ranges, or would two suffice (thus creating shorter assembly that might be a little easier to understand)? Anything else you can do to simplify the test case would be great.

Actually, why are there 3 ranges here, when it looks like there are only 2 functions? (ah, I see, invalid input/DWARF as you mentioned in the description - but still, could be simpler to have 2 functions rather than 3)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55113/new/

https://reviews.llvm.org/D55113