[PATCH] D54649: [FPEnv] Rough out constrained FCmp intrinsics

Mon Dec 3 07:57:26 PST 2018

uweigand added a comment.

In D54649#1310341 <https://reviews.llvm.org/D54649#1310341>, @cameron.mcinally wrote:

> @uweigand, what about something like this patch? The STRICT_FSETCC isn't handled all the way through the target, but it's stubbed out for now.

See inline comments.  Otherwise, I think this makes sense ...

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:81
+  case ISD::STRICT_FSETCC: 
+                         Res = PromoteIntRes_StrictFSETCC(N); break;
   case ISD::SMIN:
----------------
Just to clarify: the reason why we need to handle STRICT_FSETCC here but not any of the other STRICT_ opcodes is that only FSETCC involves an integer type (as return type), right?

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:26106
   case ISD::SETCC:              return LowerSETCC(Op, DAG);
+  case ISD::STRICT_FSETCC:      return LowerSTRICT_FSETCC(Op, DAG);
   case ISD::SETCCCARRY:         return LowerSETCCCARRY(Op, DAG);
----------------
Why do you have this here?   It seems that this can never be called right now (at least without something like my D45576, right?)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54649/new/

https://reviews.llvm.org/D54649