[PATCH] D54939: [RFC] [llvm-objcopy] Initial COFF support

Mon Dec 3 02:50:08 PST 2018

jhenderson added a comment.

In D54939#1314030 <https://reviews.llvm.org/D54939#1314030>, @mstorsjo wrote:

> In D54939#1314029 <https://reviews.llvm.org/D54939#1314029>, @alexshap wrote:
>
> > i will get to this diff early next week, sorry about the delay. A small side note - probably the simple changes to include/llvm/Object/COFF.h can be factored out from this diff and reviewed separately (and probably much faster).
>
>
> Ok - splitting them out isn't hard, but I dunno what to make as test for them, if they are going in as such.

It looks to me like they should be unit-tested. There is already a set of unit tests for LLVMObject, so it shouldn't be too hard to add them, I'd think.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54939/new/

https://reviews.llvm.org/D54939