[PATCH] D54633: [NFC][AArch64] Split out backend features

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 01:54:12 PST 2018


olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

A few nits, but otherwise LGTM, no need to re-review after fixing them.



================
Comment at: lib/Target/AArch64/AArch64.td:233
+
+def FeatureCCIDX : SubtargetFeature<
+    "hasCCIDX", "HasCCIDX", "true",
----------------
olista01 wrote:
> This feature is in AA64MMFR2_EL1.
Not done yet?


================
Comment at: lib/Target/AArch64/AArch64.td:98
+// UAO PState
+def FeaturePsUAO : SubtargetFeature< "hasPsUAO", "HasPsUAO", "true",
+    "Enable v8.2 UAO PState">;
----------------
Feature name (first parameter) still contains "has".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54633/new/

https://reviews.llvm.org/D54633





More information about the llvm-commits mailing list