[PATCH] D55102: [MachineLICM][X86][AMDGPU] Fix subtle bug in the updating of PhysRegClobbers in post-RA LICM

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 2 13:03:47 PST 2018


arsenm added inline comments.


================
Comment at: lib/CodeGen/MachineLICM.cpp:460
 
     // If we have already seen another instruction that defines the same
     // register, then this is not safe.  Two defs is indicated by setting a
----------------
Can all of this code be converted to look at RegUnits instead of using MCRegAliasIterator?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55102/new/

https://reviews.llvm.org/D55102





More information about the llvm-commits mailing list