[PATCH] D55091: Add --analyze option to llvm-dwarfdump

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In D55091#1315244 <https://reviews.llvm.org/D55091#1315244>, @probinson wrote:

> In D55091#1314919 <https://reviews.llvm.org/D55091#1314919>, @vsk wrote:
>
> > Your DWARF analysis tool presumably needs to support diffing and output serialization. So would a comprehensive code size analysis tool. There's no reason why these two tools should have different diffing / serialization options. The latter shouldn't live within a debug info specific tool. However, there's no fundamental issue with adding DWARF to the long list of formats llvm-objdump already understands. Technically, it's just a matter of linking in llvm's DWARF libraries.
>
>
> Diffing?  Of what?  If we're tracking sizes etc over time, the diffing shouldn't be in the tool.  Dump stats to a database and do the normal thing with it there.


Diffing of sizes (whether its of sections, functions, inlining trees, or something else). I do think the tool should handle diffing for the user. There's extra work and a higher learning curve involved with massaging the data into a database. Moreover, with two different tools emitting JSON with different keys, there wouldn't be a single workflow for getting the data into a separate tool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55091/new/

https://reviews.llvm.org/D55091