[PATCH] D54518: [GlobalISel] Fix insertion of stack-protector epilogue

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 15:04:48 PST 2018


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

Hi Petr,

This looks ok to me, can you separate this into two separate commits though? One for the option changes and the other for the SP fix.

Thanks,
Amara



================
Comment at: test/CodeGen/AArch64/GlobalISel/irtranslator-stackprotect-check.ll:1
+; RUN: llc -stop-before=irtranslator -global-isel %s -o - | FileCheck %s
+; RUN: llc -stop-after=irtranslator -verify-machineinstrs -global-isel %s -o - | FileCheck --check-prefixes CHECK,CHECK-MIR %s
----------------
We don't yet officially support GISel on AArch64 except for -O0, so can you add this to the run line?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54518/new/

https://reviews.llvm.org/D54518





More information about the llvm-commits mailing list