[PATCH] D54997: [DebugInfo] PR39807: Create unknown locations when hoisting to locationless blocks

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1398
+  // If an earlier instruction in this BB had a location, adopt it, otherwise
+  // clear debug locations.
+  Builder.SetCurrentDebugLocation(InsertPt ? InsertPt->getDebugLoc()
----------------
I guess this comment should explain _why_ this is happening rather than _what_; unfortunately there's little justification for this behaviour now. (IMHO something else to address in a follow-up).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54997/new/

https://reviews.llvm.org/D54997