[PATCH] D51207: Introduce llvm.experimental.widenable_condition intrinsic

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked 4 inline comments as done.
mkazantsev added inline comments.


================
Comment at: docs/LangRef.rst:15134-15137
+This intrinsic represents a "widenable condition" which is
+boolean expressions with the following property: whether this
+expression is `true` or `false`, the program is correct and
+well-defined.
----------------
chandlerc wrote:
> I really like this proposal, but the term "widenable condition" really doesn't help me understand it at all.
> 
> Have you all thought of other terminology that might work here?
> 
> Some ideas:
> 
> "equivalent condition"
> "equivalent alternative condition"
> 
> Something focusing on the fact that this intrinsic models a value which can inhabit two alternative states that are semantically equivalent when executed.
> 
> Thoughts?
This name was chosen specifically because it is supposed to be used for widening transforms. Actually the semantics that is given in LangRef is wider and has more possible applications than what I was thinking of. :)

I am open to discussion how it can be called, but how about this: we merge it as is and then continue this discussion separately. I don't really like "equivalent condition" (without context, it's unclear equivalent to what?), but I agree that we can change the name. Just let's discuss it separately and merge it as pure NFC when we settle to some option so that I could be unblocked on items where this can be used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51207/new/

https://reviews.llvm.org/D51207