[PATCH] D54924: [WebAssembly] Check if the section order is correct

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D54924#1310734 <https://reviews.llvm.org/D54924#1310734>, @aheejin wrote:

> I see.. so why wasn't it landed? It says it was stalled because we couldn't decide whether or how to check custom section orderings and orderings between custom section vs. normal sections. Do we now have consensus on that? If so landing that CL makes more sense. If not, do you think now is a good time to re-discuss it? Or would landing this CL first and decide what to do with custom sections later makes sense?
>
> The main motivation for this CL was, I had to delete code that was previously checking relative section orders in `yaml2wasm` because the previous code only checked if the section codes were monotonically increasing and the new event section had code 12, and you suggested <https://reviews.llvm.org/D54096#1295722> we should reinstate it in a separate CL.


I don't feel super strongly about it, but for completeness we do need to include custom sections in the ordering I think.

IIRC, I think i was hoping there would be a simpler way to do that the method proposed in D54096 <https://reviews.llvm.org/D54096> but maybe t here isn't.

BTW, Is there any reason you decided to do this in libBinaryFormat over libObject?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54924/new/

https://reviews.llvm.org/D54924